fix: include conditionally displaying title and description#941
Merged
JohnVillalovos merged 3 commits intoLibreBooking:developfrom Feb 3, 2026
Merged
fix: include conditionally displaying title and description#941JohnVillalovos merged 3 commits intoLibreBooking:developfrom
JohnVillalovos merged 3 commits intoLibreBooking:developfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents PHP warnings (from NULL title/description) from being emitted into the generated JavaScript inside the reservation PDF template, which previously could introduce an unescaped line break and break JS parsing.
Changes:
- Wrap ReservationTitle output in a Smarty conditional before applying
unescape/escapemodifiers. - Wrap Description output in a Smarty conditional before applying
unescape/escapemodifiers.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
with no title or description there was a PHP (I assume 8+) warning being output directly into the JavaScript code, which creates an unescaped line break that causes a JS syntax error. Now neither Title nor Description can be NULL.
JohnVillalovos
force-pushed
the
patch-2
branch
from
cc5b9bb to
d783ecf
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JohnVillalovos
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with no title or description there was a PHP (I assume 8+) warning being output directly into the JavaScript code, which creates an unescaped line break that causes a JS syntax error. Now neither Title nor Description can be NULL.