Fix permissions for OpenShift#143
Merged
colisee merged 1 commit intoLibreBooking:masterfrom Feb 7, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
considering the OpenShift case, where uid is random, and gid is root.
I modified this a bit.
First of all, the cron jobs don't need to be writeable in container, so I removed write from group root.
I removed recursive group write persmission for the all html files. It's too wide permission.
I add upload reservations dir for the reservation images so that we can give proper permissions to it.
I add write permission for root group for cache (tpl_c), config dir where the config link will be done, and also image uploads for generic and reservation resources.
I tested this by building it with podman:
podman build --cache-ttl=0 . -t librebooking-ocp:v4.1.0 --build-arg APP_GH_REF=v4.1.0both with x86_64 and arm64.
I also tested the image both with podman on x86_64 Fedora 43, and microshift on rapsberrypi 4 for arm openshift. Seems to work fine.