fix(config) time constraint 'same_day' config not working

[belcirelk]

The value 'same_day' of the config reservation.start.time.constraint is reverted to its previous value 'current'. same_day was not taken into account. The 'current' value describe more the behavior than 'same_day' since the reservations can not be changed after they are finished.

Closes #1043

[belcirelk]

Perhaps @lucs7 should take a look since he changed 'current' for 'same_day'.

[Copilot]

Pull request overview

This PR fixes a configuration bug where the value 'same_day' for reservation.start.time.constraint was not actually implemented in the codebase. The PR reverts the configuration options back to 'current' (from 'same_day'), which is the value actually recognized by the underlying implementation in Domain/Values/ReservationStartTimeConstraint.php.

Changes:

• Reverted config option from 'same_day' to 'current' in ConfigKeys.php
• Updated description to reflect correct options: 'future', 'none', 'current'
• Updated config.dist.php comment to document correct options

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
lib/Config/ConfigKeys.php	Updates the RESERVATION_START_TIME_CONSTRAINT configuration to use 'current' instead of 'same_day' and corrects the description to list the actually implemented options
config/config.dist.php	Updates the comment to reflect the correct configuration options

[JohnVillalovos]

Looks like the commit message needs a comma ':' after 'fix(config)'. Should be fix(config): time constraint 'same_day' config not working

[JohnVillalovos]

@belcirelk Thanks. I agree that docs/source/ADVANCED-CONFIGURATION.rst should also be updated. Besides that I think it looks good to merge.

[JohnVillalovos]

Thanks @belcirelk LGTM.

I'll give @lucs7 time to review. But will plan on merging it on the 18th if I don't hear any objections.

[belcirelk]

Perfect. I don't know if he had a plan to change something with that.