Configuration Refactor & .env Integration

[lucs7]

config.*.php

• Refactors the config.php structure to support a modern return-based PHP array style
• Improves error reporting setup based on LB_APP_DEBUG

configuration.php

• Adds support for environment variables via .env using phpdotenv
• Introduces a new env() helper function that mimics Laravel-style environment resolution
• Maintains backwards compatibility with the legacy $conf['settings'] format
• Updates Configurator class to output clean, pretty-formatted config files
• Creates timestamped backups (*.bck.php) of overwritten config files
• Adds a comment with timestamp to written config files
• Adds alert message to configuration page when .env file is found

ConfigKeys.php

• updated format to fit categories
• added legacy support and warning message

.env

• all settings are available as 'LB_' environment variables through environment on start or .env
• Configuration::Register now accepts an additional .env file (mostly important for testing as default .env should be in root folder)
• env vars are taken from environment or .env file and overwrite config.php settings
• .env implementation is mutable so later .envs can overwrite them (set environment vars e.g. docker will be overwritten by .env)

plugins

• updated Configuration::Register
• updated *.config.dist.php files

[JohnVillalovos]

@lucs7 Thanks.

One question. What do you think about having all of the environment variables prefixed with LB_ ? That way it is easy to know they are for LibreBooking and also less likely to have a conflict with some other program.

I'll work on finding some time over the weekend to review the whole PR.

[lucs7]

Added the prefix 'LB_' similar to how the docker imgage works

[lucs7]

@JohnVillalovos
Sorry for the large change in the codebase. I tried to to divide it but it is hard split the changes in the function calls from the change in the logic. Fortunately more than half the files are just single line changes from GetSectionKey to GetKey

[JohnVillalovos]

Thanks @lucs7

I did my best to review this but it was very large. In the future we should try to have smaller PRs and smaller commits.

But I will approve this.

[Copilot]

Pull Request Overview

This PR refactors LibreBooking's configuration system to modernize PHP config files and integrate environment variable support using .env files. The changes enable better deployment practices and maintain backward compatibility.

• Modernizes config files from legacy $conf array format to return-based PHP arrays
• Introduces .env file support for environment-based configuration overrides
• Updates plugin configuration system with new ConfigKeys classes for better type safety

Reviewed Changes

Copilot reviewed 267 out of 268 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
tpl/Admin/Configuration/manage_configuration.tpl	Updates admin configuration UI with dynamic field rendering and environment variable awareness
tests/fakes/FakeConfig.php	Refactors test configuration to support new config definition format
tests/data/*	Adds test data files for new config formats and environment variable testing
tests/WebServices/*	Updates test files to use new ConfigKeys constants
tests/Presenters/*	Updates presenter tests to use new configuration format
tests/Infrastructure/Config/ConfigTest.php	Adds comprehensive tests for new configuration system
tests/Domain/*	Updates domain tests for new config format
tests/Application/*	Updates application tests for new config format
plugins/Authentication/*	Refactors all authentication plugins to use new ConfigKeys classes
plugins/PreReservation/*	Updates pre-reservation plugins for new config format

Comments suppressed due to low confidence (3)

tpl/Admin/Configuration/manage_configuration.tpl:37

• [nitpick] The property name 'hasEnv' doesn't follow consistent naming conventions. Consider renaming to 'HasEnv' to match the other property naming pattern used in the template.

                {assign var="disabled" value=$setting->hasEnv ? 'disabled' : ''}

tests/fakes/FakeConfig.php:65

• The error message 'Config definition not found' is misleading. It should clarify that the config definition must be an array with a 'key' field, not that it wasn't found.

        if (!is_array($configDef) || !isset($configDef['key'])) {

tests/Infrastructure/Config/ConfigTest.php:97

• The test should clean up environment variables after the test runs to avoid affecting other tests. Consider using tearDown() or try-finally to ensure putenv() changes are reverted.

        putenv('DEFAULT_TIMEZONE=Europe/Berlin');

[Copilot]

The method signature change from GetConfig($keyName) to GetConfig($configDef) is inconsistent across plugins. Some plugins still use $keyName parameter name while others use $configDef. This could confuse developers and should be standardized.

[Copilot]

Unnecessary semicolon after closing brace. This is likely a leftover from refactoring and should be removed for cleaner code.

Suggested change

;

[Copilot]

The code assumes explode will always return an array with at least 2 elements when checking count($pair) === 2, but the closing brace and return statement are outside this if block. This could lead to incomplete attribute mapping if the format is incorrect.

Suggested change

	$attributes[trim($pair[0])] = trim($pair[1]);
	$attributes[trim($pair[0])] = trim($pair[1]);
	} else {
	error_log("Invalid attribute mapping pair: '{$attributePair}' in CAS attribute mapping configuration.");

[JohnVillalovos]

@lucs7 I rebased this and fixed the conflicts.