EOF Input Error during `pytest` and `run-dist.yml`

[cpstrommen]

The gh action test-lint.yml errors out during test-sniff.py every time due to a problem with reading the initial host address input in the program. Verbose error as follows:

==================================== ERRORS ====================================
_____________________ ERROR collecting tests/test-sniff.py _____________________
tests/test-sniff.py:3: in <module>
    from src.plcd.ping import portSniff
src/plcd/ping.py:[29](https://github.com/LibreCS/plcd/runs/7617169221?check_suite_focus=true#step:5:30)7: in <module>
    main()
src/plcd/ping.py:210: in main
    netLocationPLC = configure()
src/plcd/ping.py:58: in configure
    hostUsrIn = process_input(addressInMsg)
src/plcd/ping.py:[33](https://github.com/LibreCS/plcd/runs/7617169221?check_suite_focus=true#step:5:34): in process_input
    line = input(msg)
E   EOFError: EOF when reading a line
=============================== warnings summary ===============================
src/plcd/ping.py:201
  /home/runner/work/plcd/plcd/src/plcd/ping.py:201: DeprecationWarning: invalid escape sequence '\/'
    print(bcolors.HEADER + "           __         __\n    ____  / /________/ /\n   / __ \/ / ___/ __  / \n  / /_/ / / /__/ /_/ /  \n / .___/_/\___/\__,_/   \n/_/                     \n" + bcolors.ENDC)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
ERROR tests/test-sniff.py - EOFError: EOF when reading a line
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
========================= 1 warning, 1 error in 0.11s ==========================

I attempted to implement the solution found in this thread without any success. Will inform on changes and updates

[cpstrommen]

EOF Error also found when running run-dist.yml action, verbose as follows:

return _run_code(code, main_globals, None,
  File "/opt/hostedtoolcache/Python/3.10.5/x64/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/opt/hostedtoolcache/Python/3.10.5/x64/lib/python3.10/site-packages/plcd/__main__.py", line 3, in <module>
    from plcd.ping import main
  File "/opt/hostedtoolcache/Python/3.10.5/x64/lib/python3.10/site-packages/plcd/ping.py", line [28](https://github.com/LibreCS/plcd/runs/7616853920?check_suite_focus=true#step:6:29)6, in <module>
    main()
  File "/opt/hostedtoolcache/Python/3.10.5/x64/lib/python3.10/site-packages/plcd/ping.py", line 199, in main
    netLocationPLC = configure()
  File "/opt/hostedtoolcache/Python/3.10.5/x64/lib/python3.10/site-packages/plcd/ping.py", line 47, in configure
    hostUsrIn = input(addressInMsg)
EOFError: EOF when reading a line
Enter PLC plant IP address: 
Error: Process completed with exit code 1.

Preliminary assessment is EOF exception is needed for the input() call in configure() in ping.py, see above links for insight

[cpstrommen]

The call in configure():

addressInMsg = "Enter PLC plant IP address: "

    # get host input
    hostUsrIn = process_input(addressInMsg)

The function definition:

def process_input(msg):
    line = input(msg)
    while True:
        try:
            line = input(msg)
            return line
        except EOFError:
            return TEST_IP

Note: the previous implementation when this issue was started was just a direct input() call from configure()

[cpstrommen]

More elegant inline solution in this commit:

while True:
        try:
            hostUsrIn = input(addressInMsg)
            if hostValid(hostUsrIn):
                break
        except EOFError:
            hostUsrIn = TEST_IP
            break

[cpstrommen]

Inline solution fixed the issue, more pytest issues on the horizon