Skip to content

fix: avoid install failure with bool active column#61

Merged
vitormattos merged 6 commits intomainfrom
fix/issue-58-active-bool-notnull
Apr 4, 2026
Merged

fix: avoid install failure with bool active column#61
vitormattos merged 6 commits intomainfrom
fix/issue-58-active-bool-notnull

Conversation

@vitormattos
Copy link
Copy Markdown
Member

@vitormattos vitormattos commented Apr 4, 2026

Summary

  • add a regression test for migration Version1000Date20260309120000 asserting active is nullable
  • make profile_fields_definitions.active explicitly nullable in the migration while keeping default true
  • keep active=false storable across database providers/installation paths

Validation

  • composer test:unit -- tests/php/Unit/Migration/Version1000Date20260309120000Test.php (red before fix, green after fix)
  • composer cs:fix
  • composer psalm

Closes #58

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos vitormattos merged commit cb43f1d into main Apr 4, 2026
23 checks passed
@vitormattos vitormattos deleted the fix/issue-58-active-bool-notnull branch April 4, 2026 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant