Skip to content

Update from template #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2020
Merged

Update from template #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
<!-- Describe the changes you have made. -->


##### DATASHEETS / REFERENCES
<!-- When submitting a new device or package, please provide links to the
necessary datasheets, package drawings or standards documents.-->


##### OPEN QUESTIONS / UNRESOLVED ISSUES
<!-- List topics you are unsure about, if any. Otherwise, leave this empty. -->

Expand All @@ -12,7 +17,13 @@ by adding an "x" between the brackets (i.e. "[x]"). If you are unsure, leave
the corresponding items unchecked so the library maintainers know where help
is needed. -->

- [ ] I have read and followed the [library conventions](https://docs.librepcb.org/#libraryconventions).
- [ ] I have read and followed the library conventions¹.
- [ ] For packages, I followed IPC7351C (see details in library conventions).
- [ ] For modified elements, I bumped their version number².
- [ ] I already used the new library elements in a design and verified their correctness (optional).
- [ ] I'm the copyright owner of the added content (i.e. the changes are made by myself, not copied/imported from somewhere else).
- [ ] I agree to publish all my changes under the [CC0 Public Domain License](https://en.wikipedia.org/wiki/CC0), allowing everyone to use and modify the content without any restrictions.
- [ ] I agree to publish all my changes under the CC0 Public Domain License³, allowing everyone to use and modify the content without any restrictions.

¹ *Library Conventions: https://docs.librepcb.org/#libraryconventions*
² *Minor version bump if only metadata was modified (e.g. "0.1" -> "0.1.1"), major version bump if functional changes were made (e.g. "0.1" -> "0.2")*
³ *CC0 Public Domain License: https://en.wikipedia.org/wiki/CC0*
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ name: CI
on: [push, pull_request]
jobs:
check:
runs-on: ubuntu-18.04
runs-on: ubuntu-20.04
container:
image: librepcb/librepcb-cli:0.1.3
image: librepcb/librepcb-cli:0.1.5
options: --entrypoint /bin/bash
steps:
- uses: actions/checkout@v1
Expand Down