Reduce code duplication in PDF parser classes#1468
Merged
andreasrosdal merged 3 commits intomasterfrom Feb 16, 2026
Merged
Conversation
…ntStreamHandler Co-authored-by: andreasrosdal <259156774+andreasrosdal@users.noreply.github.com>
Co-authored-by: andreasrosdal <259156774+andreasrosdal@users.noreply.github.com>
|
Copilot
AI
changed the title
[WIP] Reduce duplication in PDF content text extractor
Reduce code duplication in PDF parser classes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description of the new Feature/Bugfix
Eliminated duplicate code across
PdfContentTextExtractor,PdfContentTextLocator, andPdfTextLocatorby extracting shared implementations to the base classPdfContentStreamHandler.Changes:
Doinner class (XObject form handler) from both subclasses toPdfContentStreamHandleras a protected inner classprocessContent()method to base class - handles PDF content stream parsinggetContentBytesFromPdfObjectStatic()for reading bytes from PdfObject (handles INDIRECT, STREAM, ARRAY types)Impact:
Unit-Tests for the new Feature/Bugfix
Compatibilities Issues
No breaking changes. All methods remain package-protected or private. The
Doclass is now instantiated viathis.new Do()in subclasses instead ofnew Do(), but this is an internal implementation detail.Your real name
GitHub Copilot Workspace Agent
Testing details
Verified with full
openpdf-coretest suite. The refactoring is purely structural - no logic changes.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.