Skip to content

Fix for loading of TIFF with transparency.#41

Merged
tlxtellef merged 1 commit intoLibrePDF:masterfrom
tlxtellef:master
Oct 5, 2017
Merged

Fix for loading of TIFF with transparency.#41
tlxtellef merged 1 commit intoLibrePDF:masterfrom
tlxtellef:master

Conversation

@tlxtellef
Copy link
Copy Markdown
Member

No description provided.

@tlxtellef
Copy link
Copy Markdown
Member Author

Is that really necessary for this? Don't you have write access? Besides, wouldn't it be better to just ask @bengolder directly on GitHub?

@ghost
Copy link
Copy Markdown

ghost commented Oct 3, 2017

There are 3 other people who have access. I don't have access any more. These people are @bengolder , @daviddurand and @nwinkler.

@ghost
Copy link
Copy Markdown

ghost commented Oct 3, 2017

Make sure to test this version of OpenPDF very good before considering running it in any web-based economy systems in production. I have accepted most pull-request in order to try to consolidate development of rtfarte/OpenPDF in a single open source branch. Beware that I haven't tested these changes in any web-based economy systems at all.

Maintaining your own fork of this library on GitHub is also a very valid alternative. Or try to contact @bengolder , @daviddurand or @nwinkler. This will take some effort on your part. I don't have access to this repository any more.

@asturio
Copy link
Copy Markdown
Member

asturio commented Oct 3, 2017

I don't know a way to contact another developer on GitHub without being this way, in a "discussion".

@andreasrosdal If you don't have write access, why are you the only one reacting to these pull requests? Or the other way 'round. Why are the users with write access not reacting to the requests? That ain't no good.

@ghost
Copy link
Copy Markdown

ghost commented Oct 3, 2017

@asturio I still hope that you or @tttellef will be able to contact one of the three other developers. You probably have to try harder, using some other communcation channel, such as e-mail or twitter. I used to be one of the developers on this project, but made a decision that I had to prioritize other things about one month ago. For quite some time I have been the one reviewing pull-requests to this project. There are now three other developers, but it seems they are not very active. I think you should be able to contact them. Try harder, and not just in this thread. :)

If you are not able to contact them, then you are free to start a new fork on GitHub. Perhaps cooperate with @tttellef. Development can happen in any fork, not just this one. For example, https://github.com/OpenPDF/OpenPDF/ is still available. It is all up to you. Good luck!

http://benjamingolder.com

@nwinkler
Copy link
Copy Markdown

nwinkler commented Oct 4, 2017

Sorry, I am no longer working on this project - too many other commitments.

@ghost
Copy link
Copy Markdown

ghost commented Oct 4, 2017

@nwinkler Do you still have admin access? Can you please give admin access to @tttellef ?

@nwinkler
Copy link
Copy Markdown

nwinkler commented Oct 4, 2017

No, sorry, don't have admin access anymore...

@tlxtellef
Copy link
Copy Markdown
Member Author

@andreasrosdal https://github.com/OpenPDF/OpenPDF/ doesn't exist, 404

Copy link
Copy Markdown
Member

@daviddurand daviddurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This includes a test, which passes, seems unlikely to raise new issues, and seems approvable to me.

I am not sure at this point how to carry out the release process, but I will investigate; we probably want to accumulate changes into batches before performing releases; perhaps this is worth discussing, as the alternative (to release whenever changes are made), may make as much sense, given that this is a pretty low-intensity fix-tracking project.

@daviddurand
Copy link
Copy Markdown
Member

I made a number of fixes, and some changes/improvements to the text extraction API, as I use this PDF library, and did not want to follow to the new license. I was invited to contribute after my branch was pulled into the the new fork.

I don't have a lot of time to be an organizer, but I am happy to participate as I can. Certainly If I fix any more bugs, I will submit my own pull requests.

I have no administrative privileges, so issues like that must be handled by the owner, @bengolder.

@ghost
Copy link
Copy Markdown

ghost commented Oct 5, 2017

@tttellef You are now admin on this project!

@tlxtellef tlxtellef merged commit fc7a645 into LibrePDF:master Oct 5, 2017
@ghost
Copy link
Copy Markdown

ghost commented Oct 5, 2017

This is how to make a release: https://github.com/LibrePDF/OpenPDF/wiki/Release-Process

I still have access to make releases to maven central of OpenPDF, so I can probably help to request permission to make released for you, if you want that.

@bengolder
Copy link
Copy Markdown
Collaborator

Apologies to everyone regarding the confusion over access. I haven't had time to act as a maintainer and had assumed that others had admin abilities.

@tlxtellef
Copy link
Copy Markdown
Member Author

@bengolder @andreasrosdal So, making a release is the next thing.

@ghost
Copy link
Copy Markdown

ghost commented Oct 10, 2017

Please read this: https://github.com/LibrePDF/OpenPDF/wiki/Release-Process

  1. Create a new Sonatype JIRA login.
  2. If you need anything from me so that you can create releases of OpenPDF, please ask. I have permission to create releases.

@tlxtellef
Copy link
Copy Markdown
Member Author

@andreasrosdal Well, I lack permissions for the staging profile.

@ghost
Copy link
Copy Markdown

ghost commented Oct 10, 2017

@tttellef Let me know if you want me to do anything then.

@tlxtellef
Copy link
Copy Markdown
Member Author

@andreasrosdal Then create a release as it seems I can't.

@ghost
Copy link
Copy Markdown

ghost commented Oct 10, 2017

What is your Sonatype account username?

@tlxtellef
Copy link
Copy Markdown
Member Author

tlxtellef

@ghost
Copy link
Copy Markdown

ghost commented Oct 10, 2017

Please follow the progress here: https://issues.sonatype.org/browse/OSSRH-35105

@ghost
Copy link
Copy Markdown

ghost commented Oct 10, 2017

Permissions granted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants