Skip to content

ItEr76S13WBSSettingUpBehavior

Jump to bottom
Jeroen Baten edited this page Mar 9, 2018 · 1 revision

TWiki> LibrePlan Web>ItEr76S13WBSSettingUpBehavior (20 Aug 2012, ManuelRego)EditAttach

ItEr76S13WBSSettingUpBehavior

Story summary Improve WBS Configuration Behavior
Iteration ItEr76Week01To33
FEA ItEr76S13WBSSettingUpBehavior
Story Lead  
Next Story  
Passed acceptance test No

Acceptance Criteria

Additional Specification Comments

Implementation Notes

Change leaf creation behavior when selected parent is a leaf with zero hours

To implement this new behavior 2 new methods were added to org.libreplan.business.trees.ITreeNode:

  • isEmptyLeaf(): To check if a leaf is or not empty (no hours, no criteria, no progresses...). This method is used in org.libreplan.web.tree.EntitiesTree.turnIntoContainerIfNeeded(ITreeNode? ), if true the leaf is not added to the new container created.
  • isLeaf(): To avoid using org.libreplan.web.tree.TreeController.isLine(T) (that has been removed). isLine() checked that the element has not children, but after adding the previous condition when you're creating the container and the leaf is empty, as you're not adding the leaf, the container has not children for a while, however it's a leaf (or line).

Moreover the method org.libreplan.web.tree.EntitiesTree.addElementAt(T, String, int) has been modified and now it returns the new element. This is used in org.libreplan.web.tree.TreeController.addElement(Component) to update the hours input in the new element and parents. As now if the leaf is empty the old element is removed you cannot use it to update the hours inputs.

Finally, org.libreplan.business.orders.entities.OrderLine.toContainer() was modified to keep the task name if the leaf is empty. Otherwise, new container is used for the moment.

Change leaf creation behavior when selected a not empty leaf task

The first part of this task (put an empty name) is already pushed. It just needed a change in the method org.libreplan.business.orders.entities.OrderLine.toContainer(). Then it was needed to fix some tests in OrderElementTreeModelTest.

To fix the issue with the focus, a new map has been added org.libreplan.web.tree.TreeController.Renderer.nameTextboxByElement in order to know the Textbox corresponding to the different tasks.
 

Delay Causes

Final or Pending Considerations
 

Commits

%RPSHOWGITCOMMITS%

Tasks in this story

Tasks Est Spent To do Risk Reviewer Developer Task Name Start Date Est End Date End Date
Task 7 6.75 0 Low JavierMoran ManuelRego Change leaf creation behavior when selected parent is a leaf with zero hours      
Task 3 2 0 Low JavierMoran ManuelRego Change leaf creation behavior when selected a not empty leaf task      

Total Hours in this Story

User Spent in XpTracker Spent in phpReport Ok?
ManuelRego 8.75 0 ALERT!
Total 8.75 0 ALERT!

Copyright (c) by the contributing authors. All material on this collaboration platform is the property of the contributing authors.

Clone this wiki locally