Skip to content

Set TZ=UTC for pdfsig#5424

Merged
vitormattos merged 3 commits intoLibreSign:mainfrom
oktay454:main
Sep 10, 2025
Merged

Set TZ=UTC for pdfsig#5424
vitormattos merged 3 commits intoLibreSign:mainfrom
oktay454:main

Conversation

@oktay454
Copy link
Copy Markdown
Contributor

Pull Request Description

Servers whose time zone is not UTC will receive "Invalid signingTime in certificate chain. We found Marty McFly" error.
pdfsig and pdfinfo commands TZ=UTC variable with when executed problem fixed

NextCloud 31
LibreSign 11.3.2

Related Issue

Issue Number: #5347

Pull Request Type

  • Bugfix

Pull request checklist

  • Did you explain or provide a way of how can we test your code ?
  • Did you provide a general summary of your changes ?
  • I implemented tests that cover my contribution

@github-project-automation github-project-automation Bot moved this to 0. Needs triage in Roadmap Sep 10, 2025
@oktay454 oktay454 mentioned this pull request Sep 10, 2025
@oktay454 oktay454 changed the title Set TZ=UTC for pdfsig and pdfinfo command [#5347] Set TZ=UTC for pdfsig and pdfinfo command Sep 10, 2025
Copy link
Copy Markdown
Member

@vitormattos vitormattos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a handmade test here at the terminal and worked fine:

~/Downloads$ env TZ=Europe/Berlin  pdfsig test_signed.pdf
Digital Signature Info of: test_signed.pdf
Signature #1:
  - Signing Time: Sep 09 2025 14:39:23
~/Downloads$ env TZ=America/Sao_Paulo  pdfsig test_signed.pdf
Digital Signature Info of: test_signed.pdf
Signature #1:
  - Signing Time: Sep 09 2025 09:39:23

Will be only necessary a small change to go ahead.

Comment thread lib/Service/PdfParserService.php Outdated
oktay454 and others added 2 commits September 10, 2025 17:43
Co-authored-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Kemal Oktay <iletisim@oktayaktogan.com.tr>
Signed-off-by: Kemal Oktay <iletisim@oktayaktogan.com.tr>
@vitormattos
Copy link
Copy Markdown
Member

vitormattos commented Sep 10, 2025

Sounds good! Since this change only affects a single line, could you squash, rebase, and fix the DCO and unconventional commits issues locally?

@oktay454
Copy link
Copy Markdown
Contributor Author

Sounds good! Since this change only affects a single line, could you squash, rebase, and fix the DCO and unconventional commits issues locally?

I don't quite understand. Should I cancel this PR and send a new one?

@vitormattos
Copy link
Copy Markdown
Member

Should I cancel this PR and send a new one?

Isn't necessary.

Only to identify how can I help you to go ahead, did you made this change locally or did you used the GitHub interface to edit the code directly at the browser?

@oktay454
Copy link
Copy Markdown
Contributor Author

Should I cancel this PR and send a new one?

Isn't necessary.

Only to identify how can I help you to go ahead, did you made this change locally or did you used the GitHub interface to edit the code directly at the browser?

Local. Then I sent a pull request from the Github page.

@vitormattos
Copy link
Copy Markdown
Member

I will made here, don't worry.

@vitormattos vitormattos merged commit 22b2905 into LibreSign:main Sep 10, 2025
54 of 56 checks passed
@github-project-automation github-project-automation Bot moved this from 0. Needs triage to 4. to release in Roadmap Sep 10, 2025
@vitormattos
Copy link
Copy Markdown
Member

I remembered that is possible to swash the commits at the PR, directly by GitHub page.

Thanks again by your contribution!

@vitormattos
Copy link
Copy Markdown
Member

/backport to stable32

@vitormattos
Copy link
Copy Markdown
Member

/backport to stable31

@vitormattos
Copy link
Copy Markdown
Member

/backport to stable30

vitormattos added a commit that referenced this pull request Sep 11, 2025
Co-authored-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Kemal Oktay <iletisim@oktayaktogan.com.tr>
vitormattos added a commit that referenced this pull request Sep 11, 2025
Co-authored-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Kemal Oktay <iletisim@oktayaktogan.com.tr>
@vitormattos vitormattos changed the title Set TZ=UTC for pdfsig and pdfinfo command Set TZ=UTC for pdfsig Sep 11, 2025
@LibreSign LibreSign deleted a comment from backportbot-libresign Bot Sep 11, 2025
@LibreSign LibreSign deleted a comment from backportbot-libresign Bot Sep 11, 2025
@LibreSign LibreSign deleted a comment from backportbot-libresign Bot Sep 11, 2025
vitormattos added a commit that referenced this pull request Sep 11, 2025
Co-authored-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Kemal Oktay <iletisim@oktayaktogan.com.tr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants