fix: make possible to test with dates#5535
Merged
vitormattos merged 7 commits intomainfrom Oct 9, 2025
Merged
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes date handling in tests by implementing proper mocking of time dependencies and using fixed dates for consistent test execution. The change enables deterministic testing by eliminating reliance on the current system time.
- Changed
ITimeFactoryfrom concrete dependency to mocked object in tests - Replaced dynamic date creation with fixed UTC timestamps
- Modified
getStartTime()method to use injected time factory instead of creating new DateTime instances directly
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/php/Unit/Service/ReminderServiceTest.php | Mock ITimeFactory and use fixed timestamps for deterministic testing |
| lib/Service/ReminderService.php | Refactor getStartTime() to use injected time factory for better testability |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
Author
|
/backport to stable32 |
Member
Author
|
/backport to stable31 |
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
G will return 0 to 23 H will return 00 to 23 G will return without left zero when is a number with only a digit. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
github-project-automation
Bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
This was referenced Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.