[stable32] fix: preserve selected nodeid#6329
Merged
Merged
Conversation
…ifier Fix issue where selectedNodeId was being reset to 0 when addFile() called getAllFiles(). The getAllFiles method resets selectedNodeId when the file doesn't exist in the store yet, causing problems when adding new files from the Nextcloud Files app. Also update payload logic in saveWithVisibleElements and updateSignatureRequest to send either fileId (for existing LibreSign files) or nodeId (for new Nextcloud files) based on whether file.id exists. This ensures the backend receives the correct identifier type for each scenario. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Convert addFile() calls to await to ensure proper async handling when adding files from the Nextcloud Files app sidebar. This prevents race conditions where selectFile() might be called before the file is fully added to the store. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Convert initFromState() to async and await addFile() call to ensure proper initialization when loading file state. This maintains consistency with other addFile usage throughout the codebase. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
github-project-automation
Bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #6327