fix: add able to sign getter#6705
Merged
vitormattos merged 2 commits intomainfrom Feb 3, 2026
Merged
Conversation
The ableToSign getter was missing from the sign store, causing the Sign component to fall into the 'Unable to sign' state even when all conditions were met. The getter checks: - Document status is ABLE_TO_SIGN or PARTIAL_SIGNED - There is a signer with me: true - Signer status is 1 (ABLE_TO_SIGN) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Adds comprehensive test coverage for the ableToSign getter including: - Document status validation - Signer presence validation - Signer status validation - Edge cases (undefined document, empty signers array) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
github-project-automation
Bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
This was referenced Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.