-
-
Notifications
You must be signed in to change notification settings - Fork 103
fix: docmdp certification level and visibility #6784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vitormattos
merged 8 commits into
main
from
fix/docmdp-certification-level-and-visibility
Feb 8, 2026
Merged
fix: docmdp certification level and visibility #6784
vitormattos
merged 8 commits into
main
from
fix/docmdp-certification-level-and-visibility
Feb 8, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow multiple DocMDP signatures (ISO 32000-1 violation) instead of dropping to NOT_CERTIFIED - Add docmdp_validation warning when multiple certifying signatures detected - Implement getIsoComplianceStatus() to track ISO violations - Update validateSingleDocMdpSignature() to count actual certifying signatures - Preserve certification level from first signature while warning user Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Move -cl (certification) flag logic to apply only when no visible elements AND no existing signatures - In signUsingVisibleElements(), apply -cl only to first element (elementIndex === 1) - Add hasExistingSignatures() to detect prior signatures by regex patterns - Prevent duplicate DocMDP application across multiple visible signature positions Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Add docmdp_validation field propagation in loadSignersFromCertData() - Preserve ISO compliance status when loading certificate data - Allow frontend to display warnings about multiple DocMDP signatures - Maintain separation between docmdp (level/info) and docmdp_validation (warnings) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Show warning icon and message when docmdp_validation is present - Include docmdp_validation in hasDocMdpInfo computed property - Alert users about ISO 32000-1 violations (multiple DocMDP signatures) - Maintain visual consistency with existing validation indicators Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Add /Contents entry to certifying signatures in createPdfWithMultipleDocMdpSignatures() - Ensure fixtures count as valid ISO 32000-1 certifying signatures - Support tests that validate DocMDP preservation with warnings - Maintain PDF structure compliance for handler validation tests Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Replace testRejectsMultipleDocMdpSignatures with two focused tests - testPreservesDocMdpLevelWithMultipleSignatures: validates level preservation (ISO 32000-1 12.8.2.2) - testWarnsWhenMultipleDocMdpSignaturesViolateIso: validates warning generation (ISO 32000-1 12.8.2.2.1) - Each test has single responsibility and explicit ISO reference Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- testDocMdpAppliedOnlyOnFirstVisibleElement: validates -cl only on first element with 2 visible positions - testDocMdpSkippedWhenSignatureExists: validates -cl skipped when prior signature detected - Add setDocMdpConfigService() helper for test mocking - Cover new DocMDP single-certification business rules Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Assert docmdp_validation field is present in loaded signer objects - Validate propagation of ISO compliance warnings through data pipeline - Add coverage for docmdp_validation in existing comprehensive test case - Ensure warnings reach frontend validation UI from backend Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
This was referenced Feb 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.