[stable32] feat: implement more e2e tests#7127
Merged
vitormattos merged 12 commits intostable32from Mar 5, 2026
Merged
Conversation
…oint Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…sign link When an authenticated Nextcloud user navigates to a sign link whose email does not match their own account email, LibreSign must block the attempt and display a clear error message instead of silently failing. The test logs in as admin (admin@email.tld), creates an email-only sign request for signer01@libresign.coop, then navigates to the sign link without logging out. The backend returns ACTION_DO_NOTHING (2000) and the frontend must render the error message: 'This document is not yours. Log out and use the sign link again.' Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
When the backend returns ACTION_DO_NOTHING (2000) — e.g. when an authenticated user accesses a sign link that belongs to a different email address — ExternalApp.vue was unconditionally rendering the sign view and the RightSidebar, resulting in a loading spinner and hiding the actual error message. Show DefaultPageError and hide RightSidebar when isDoNothingError, mirroring the existing behaviour in App.vue. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
When errors are present via initial state the generic 'Page not found'
title and 'Sorry but...' description are misleading. Replaced with
computed title ('An error occurred' vs 'Page not found') and computed
description (empty when errors exist) so that error scenarios like the
wrong-session case display a meaningful heading.
Also added width: 100% to .error-page so it fills the full horizontal
width inside the flex container of ExternalApp.
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Cover both states of isDoNothingError: - normal load: router-view and RightSidebar are rendered, DefaultPageError is not - DO_NOTHING action: DefaultPageError is shown, RightSidebar and router-view are hidden Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…splay Cover all branches of the errors computed property: - errors[] with items: title 'An error occurred', NcNoteCard with message - no data: title 'Page not found', description shown, no NcNoteCard - empty errors[] but error.message present: fallback to singular object Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
When the signer's email matches the authenticated user's Nextcloud account email, LibreSign must allow the sign flow to proceed normally through the email+token identify method. The test logs in as admin (admin@email.tld), creates an email-only sign request using that same address, stays logged in, follows the sign link from the notification email, submits the token received in the email, and signs with click-to-sign — asserting the document reaches the signed state. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Replace NcListItem with plain divs for multi-line cert details - Use dl/dt/dd semantic structure for screen readers - Add aria-expanded, aria-label on toggle button and cert items - Fix layout spacing and reset browser defaults on dt/dd - Add TRANSLATORS comments with PKI context for non-technical translators - Fix CSS typo: phain-wrapper -> padding-left Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Test aria-expanded state on header (true/false) - Test aria-label on each certificate item - Test dl/dt/dd semantic structure for certificate fields - Test toggle button aria-label changes with open/close state Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
github-project-automation
bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #7074