[stable32] fix: error handling and crl delete#7154
Merged
vitormattos merged 8 commits intostable32from Mar 5, 2026
Merged
Conversation
Call CRL revocation by user UID before deleting the PFX file. Use CESSATION_OF_OPERATION with a reason description to keep auditability when certificates are removed by the account owner. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Differentiate certificate validation errors from missing-signature-password flow.\n\nUse HTTP 422 for revoked, invalid, expired, and unverifiable revocation status cases to avoid incorrect UI actions. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Add test to ensure certificate validation API errors are kept as signError. Assert the store preserves the original API message list and does not infer missing-certification actions. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Add submitSignature test for API signError with revoked certificate response. Verify the certificate modal is not opened and signing errors are stored for user feedback. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Cover handler behavior for certificate revocation errors returned as code 422. Ensure these errors do not trigger signature password creation actions. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Inject CrlService in AccountService test setup and assert deletePfx behavior. Verify revocation is called with owner UID, reason code, and reason text before deleting the PFX. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Expand certificate validation tests to assert LibresignException error codes. Cover 422 for revoked, expired, invalid, and revocation-status-unverifiable certificate scenarios. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
github-project-automation
Bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #7150