Fix mobile signature placement flow, save visibility, and coordinate serialization#7342
Fix mobile signature placement flow, save visibility, and coordinate serialization#7342Phillipxh wants to merge 4 commits intoLibreSign:mainfrom
Conversation
|
Thanks for opening your first pull request in this repository! ✌️ |
|
@maintainers could you please approve workflows for this first-time contributor PR? |
4667bbb to
f6ccad9
Compare
|
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Signed-off-by: Phillip <phillipxh@gmail.com>
Signed-off-by: Phillip <phillipxh@gmail.com>
985f29e to
2a18478
Compare
Signed-off-by: Phillip <phillipxh@gmail.com>
|
Update: I pushed additional test coverage for the mobile signature placement changes (PdfEditor + VisibleElements specs). Local verification:
Could a maintainer please approve and run the pending workflows for this fork PR so CI/Codecov can refresh on the latest commit? Thanks! |
|
Quick status update on the conventional-commits check:
Could a maintainer please approve workflows and re-run checks for the latest head commit? Thank you! |
Signed-off-by: Phillip <phillipxh@gmail.com>
|
Follow-up fix pushed for mobile self-signing:
Local verification:
|
vitormattos
left a comment
There was a problem hiding this comment.
Could you directly into @libresign/pdf-elements ?
|
Thanks for the review, that makes sense. You are right that the touch-placement/runtime workaround should live in @libresign/pdf-elements instead of being implemented in libresign. I will move the fix into LibreSign/pdf-elements, open a companion PR there, and then update this PR to consume the new package version while keeping only integration-level changes/tests here. |
|
Correction to my previous comment (formatting issue): Thanks for the review, that makes sense. You're right that the touch-placement/runtime workaround should live in @libresign/pdf-elements instead of being implemented in libresign. I will move the fix into LibreSign/pdf-elements, open a companion PR there, and then update this PR to consume the new package version while keeping only integration-level changes/tests here. |
|
Update: I moved the touch-placement fix into @libresign/pdf-elements as requested.\n\nCompanion PR: https://github.com/LibreSign/pdf-elements/pull/49\n\nOnce that PR is merged and released, I can update this libresign PR to consume the new package version and keep only integration-side changes here. |
vitormattos
left a comment
There was a problem hiding this comment.
@Phillipxh I published a new release https://github.com/LibreSign/pdf-elements/releases/tag/v1.1.4
Could you go ahead now with the fixed release of pdf-elements package?
📝 Summary
This PR resolves several mobile UX issues and fixes a coordinate serialization bug affecting signature placement:
@libresign/pdf-elements.🧪 How to Test
Checkout this branch and run:
Open LibreSign and navigate to the signature position modal for a document.
On Mobile Viewport
Select a signer.
Tap once on the PDF to place the signature.
Sticky Actions
Add multiple signers to create a long sidebar.
Drag & Interaction
Move an existing signature.
Persistence
Save and reload the document.
🎨 UI / Frontend Changes
VisibleElements.vuePdfEditor.vuevite.config.mjs⚙️ API / Backend Changes
src/store/files.js✅ Checklist
npm run devbuilds successfully🤖 AI Usage
Parts of this PR were generated or assisted by AI.