fix(appstore): copy dist only if directory exists#7425
Merged
vitormattos merged 1 commit intomainfrom Apr 6, 2026
Merged
Conversation
The dist/ directory is not always produced by the frontend build (e.g. in the GitHub Actions release workflow where vite outputs the pdf worker to js/ instead). Make the copy conditional, consistent with the verify-appstore-package target which already uses an if [ -d dist ] guard. [skip ci] Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
github-project-automation
Bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
appstoreMakefile target unconditionally copies thedist/directory:cp -r \ appinfo \ css \ dist \ ← fails when absent js \ ...The GitHub Actions release workflow runs
npm run build(via Vite +@nextcloud/vite-config), which outputs the pdf worker tojs/— notdist/. Sincedist/is not created by the build in CI,make appstorefails with:This caused the v12.4.1 and v13.2.1 release workflows to fail (fixed on stable32/stable33 via PRs #7423 and #7424).
Fix
Remove
distfrom the unconditionalcp -rand add a conditional guard (identical to whatverify-appstore-packagealready does):if [ -d dist ]; then \ cp -r dist $(appstore_sign_dir)/$(app_name)/; \ fiConsistent with the existing conditional in
verify-appstore-package.