Skip to content

fix: return 404 when pdf node is missing#7534

Merged
vitormattos merged 1 commit intomainfrom
fix/7494-invalid-node-external-id-docs
Apr 21, 2026
Merged

fix: return 404 when pdf node is missing#7534
vitormattos merged 1 commit intomainfrom
fix/7494-invalid-node-external-id-docs

Conversation

@vitormattos
Copy link
Copy Markdown
Member

@vitormattos vitormattos commented Apr 21, 2026

Summary

Fixes #7494

Map FolderService NotFoundException to DoesNotExistException in AccountService::getPdfByUuid so PageController can return HTTP 404 instead of triggering a fatal error in external signer validation flows.

Add regression coverage for the node-missing path in AccountServiceTest.

Fixes #7494

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@github-project-automation github-project-automation Bot moved this to 0. Needs triage in Roadmap Apr 21, 2026
@vitormattos
Copy link
Copy Markdown
Member Author

/backport to stable32

@vitormattos
Copy link
Copy Markdown
Member Author

/backport to stable33

@vitormattos vitormattos merged commit b472453 into main Apr 21, 2026
76 checks passed
@vitormattos vitormattos deleted the fix/7494-invalid-node-external-id-docs branch April 21, 2026 18:49
@github-project-automation github-project-automation Bot moved this from 0. Needs triage to 4. to release in Roadmap Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 4. to release

Development

Successfully merging this pull request may close these issues.

[NC 33] OCP\Files\NotFoundException "Invalid node" on identity files uploaded by external signers

1 participant