fix: allow signing for legacy certificates missing CRL metadata (fixes #7597)#7605
Merged
vitormattos merged 11 commits intomainfrom Apr 25, 2026
Merged
fix: allow signing for legacy certificates missing CRL metadata (fixes #7597)#7605vitormattos merged 11 commits intomainfrom
vitormattos merged 11 commits intomainfrom
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
github-project-automation
Bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
This was referenced Apr 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a regression reported in #7597 where signing fails with:
for legacy certificates after upgrade.
Root Cause
Password::validateCertificateRevocation()treatedCrlValidationStatus::MISSINGas a hard failure and blocked signing.For legacy certificates issued before CRL metadata/URLs were present, this made signing impossible after upgrade.
What changed
tests/php/Unit/Service/IdentifyMethod/PasswordTest.phpforcrl_validation = MISSINGexpecting successful signing.lib/Service/IdentifyMethod/SignatureMethod/Password.phpto allow signing when status isMISSING, with warning log for observability.Reproduction evidence (before fix)
Filtered unit test run failed with the exact issue message:
PasswordTest::testValidateToSignWithCertificateDatadata set "invalid certificate - crl missing"LibresignException: This certificate has no revocation information. Signing is not allowed. Contact your administrator.Validation (after fix)
composer test:unit -- --filter PasswordTest::testValidateToSignWithCertificateData✅composer test:unit -- --filter PasswordTest✅Notes
This preserves revocation blocking for other unsafe statuses (
REVOKED,URLS_INACCESSIBLE,VALIDATION_ERROR,VALIDATION_FAILED,NO_URLS) and only relaxes legacy compatibility forMISSING.