Skip to content

fix: hide account identifier from SignerCommonName#7608

Merged
vitormattos merged 1 commit intomainfrom
fix/6989-filter-account-cn
Apr 25, 2026
Merged

fix: hide account identifier from SignerCommonName#7608
vitormattos merged 1 commit intomainfrom
fix/6989-filter-account-cn

Conversation

@vitormattos
Copy link
Copy Markdown
Member

@vitormattos vitormattos commented Apr 25, 2026

Summary

  • filter account:-prefixed CN entries when normalizing certificate CN values for signature params
  • keep only human-readable CN values for SignerCommonName
  • add unit coverage for legacy AD/LDAP CN arrays containing account: + display name
  • remove unrealistic fallback scenario from test coverage

Why

Issue #6989 reported {{SignerCommonName}} problems for AD users. The previous normalization fixed Array output but could still expose internal identifiers like account:johndoe alongside the display name.

Validation

  • composer test:unit -- --filter testGetSignatureParamsCommonName (inside container)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@github-project-automation github-project-automation Bot moved this to 0. Needs triage in Roadmap Apr 25, 2026
@vitormattos
Copy link
Copy Markdown
Member Author

/backport to stable33

@vitormattos
Copy link
Copy Markdown
Member Author

/backport to stable32

@vitormattos vitormattos merged commit 02cb032 into main Apr 25, 2026
80 of 84 checks passed
@vitormattos vitormattos deleted the fix/6989-filter-account-cn branch April 25, 2026 17:53
@github-project-automation github-project-automation Bot moved this from 0. Needs triage to 4. to release in Roadmap Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 4. to release

Development

Successfully merging this pull request may close these issues.

1 participant