fix: normalize canvas dimensions in ItemEventsMixin to support zoom #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mixin was returning canvas.width/height which changes when the VuePdfEditor scale property changes (zoom). This caused element positioning issues: - Elements would move to (0,0) on initial render - Drag boundaries would be incorrect after zoom - Saved coordinates would be inconsistent This fix caches the normalized canvas dimensions (at scale 1.0) and returns them consistently, ensuring elements maintain correct positioning regardless of zoom level. The implementation: - Lazy initializes normalized dimensions on first call - Traverses parent tree to find VuePdfEditor and get current scale - Divides canvas dimensions by scale to normalize to 1.0 - Returns large values during initial render to avoid constraining Benefits all components using the mixin: - TextItem.vue - Image.vue - Drawing.vue - DrawingCanvas.vue - Custom components (e.g., Signature.vue) Fixes element positioning with zoom operations. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mixin was returning canvas.width/height which changes when the VuePdfEditor scale property changes (zoom). This caused element positioning issues:
This fix caches the normalized canvas dimensions (at scale 1.0) and returns them consistently, ensuring elements maintain correct positioning regardless of zoom level.
The implementation:
Benefits all components using the mixin:
Fixes element positioning with zoom operations.