Conversation
44b1a19 to
85d17e1
Compare
vbroadcast didn't work properly for some reason, vload does..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legendre transforms copied from the Commander 2 project, then modified to use Libsharp's vecsupport.h.
I've added some extra functions in vecsupport, in particular
loadufor vector loads, and single precision versions of the functions I needed.The Makefile now depends on
md5sumandcutto verify thatlegendre_transform.c.inhasn't changed. If it does change, a Python installation with Jinja is needed to build.I've also added a very small Python wrapper for Legendre transforms, which I used to write the test suite. Like the Fortran wrapper it doesn't affect the rest, just lies there, except
make pytestwill build it and run tests.It's tested on VLEN=1,2,4 and USE_FMA=0,1. It is not tested on MIC. Currently building on MIC will fail; we could change this to exclude the Legendre transforms, or Martin tests this on MIC..
There's three new compilation flags:
-DVLEN=2: Override detection by defining a vector length (in order to test VLEN 2 and 1 on an AVX machine)-DUSE_FMA4=0To turn off FMA4 on a machine supporting it-DNO_LEGENDRE=1To turn off Legendre transforms. This is currently needed to build on MIC until the feature is tested...-DSHARP_LEGENDRE_CS=4How many vectors to put in CPU pipeline at the time; I once benchmarked 4 to be best and simply default to this rather than tune for now.Tested cases:
To test