fix(land-docs,land-plan-docs): gh repo view takes the repo positionally, not --repo#210
Merged
Merged
Conversation
…ly, not --repo `gh repo view --repo "$ORIGIN"` fails with "unknown flag: --repo" (gh has no -R/--repo on `repo view`; the repo is a positional arg — unlike gh pr/issue/api). It empties BASE and breaks BASE resolution in both land-docs and land-plan-docs. The wrong form originated in the land-plan-docs-gh-git-boundary-gotchas solution doc's own §2 "fix" recipe and was copied into both skills (land-docs in #206, land-plan-docs in #173). Correct all three to the positional form and teach the distinction in the gotchas doc. Discovered while running the compound data lane for #182. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gh repo view --repo "$ORIGIN" --json defaultBranchReffails withunknown flag: --repo(verified on gh 2.96.0). Unlikegh pr/gh issue/gh api,gh repo viewtakes the repository as a positional argument — it has no-R/--repoflag. The bad form emptiesBASE, breaking default-branch resolution in the two data-lane skills.Root cause / provenance
The wrong recipe originated in
docs/solutions/integration-issues/land-plan-docs-gh-git-boundary-gotchas.md§2 (its "fix" for theorigin/HEAD-unset gotcha) and was then copied verbatim into:land-plan-docs/SKILL.md:122(in feat: add the land-plan-docs skill #173)land-docs/SKILL.md:74(in fix: make land-* post-merge cleanup worktree-aware #206)A wrong "fix" recipe in a solutions doc propagated into two skills — a good argument for the compound step actually running the recipes it documents.
Changes
land-docs/SKILL.md:74— positionalgh repo view "$ORIGIN".land-plan-docs/SKILL.md:122— positionalgh repo view "$ORIGIN".land-plan-docs-gh-git-boundary-gotchas.md§2 — corrected recipe + a note teaching thatgh repo viewis positional (no--repo).Testing
bun test→ 513 pass / 0 fail;bun run typecheckclean; no bare-backtick ref links.gh repo view --repo Life-With-Data/agentic-engineering …→unknown flag: --repo;gh repo view Life-With-Data/agentic-engineering …→main.Post-Deploy Monitoring & Validation
Docs-only skill markdown + a solution doc — no runtime service.
land-docs/land-plan-docsresolveBASEcorrectly when actually invoked (previouslyBASE="").git checkout ""failure →git revertthis docs commit.No additional operational monitoring required: docs-only change, no production/runtime impact.Note
This branch touches
land-plan-docs/SKILL.md:122only; a separate in-flight change fixes its idempotencyif-block at:77-88(different lines, no conflict).