fix(wf-skills): state owned lifecycle transitions as observable postconditions and enforce the mapping with a guardrail test

[aagnone3]

Closes #262

Summary

• Router-level postconditions (docs(wf-skills): state owned lifecycle transitions as observable postconditions in the wf-* routers #263): the three transition-owning workflow routers now state their completion boundaries as observable board postconditions with read-back commands, not prose judgments — wf-grooming (--groom-verify <N>: Status >= planned on read-back, plus the parent-is-the-claim-unit handoff rule), wf-development (--claim proceed = in_progress; exit = --set-status <N> in_review, refused while sub-issues remain open), wf-delivery (Status = done verified via --reconcile / --delete-packet, not merge-command return). The four routers that own no board transition are deliberately unchanged.
• Guardrail test (test(plugin): guardrail — every owned lifecycle transition maps to an engine procedure and read-back #264): plugins/agentic-engineering/tests/skill_transition_ownership_test.py freezes the invariant — every skill in the OWNED_TRANSITIONS map must reference its transition's engine procedure and read-back somewhere in SKILL.md + references, asserted category-level (verb tokens, never frozen prose); an inverse guard fails any unmapped wf-* skill whose Owns: block claims a transition. Origin incident and dispositions are recorded in Guardrail owned lifecycle transitions: router-level postconditions + a lint binding every owned transition to its engine procedure #262.

Testing

• bun test (426 pass), bun run typecheck, bun run docs:build && bun run docs:check all green; full Python suite via python3 -m unittest discover -s plugins/agentic-engineering/tests -p '*_test.py' green (new module auto-discovered by the CI pattern).
• Real mutation check: stripping --groom-verify from wf-grooming's files makes the guardrail fail naming the skill and missing token; restored, suite green.

Post-Deploy Monitoring & Validation

• If no operational impact
  • No additional operational monitoring required: plugin prose and a repository test only; no runtime code paths changed.

---

🤖 Generated with Claude Code

[aagnone3]

wf-review: comprehensive review — verdict: ready

Conformance (independent acceptance-criteria pass): every criterion of #262, #263, and #264 verified against the diff; all validation commands re-run green (Python suite 425 incl. the new module's 8 tests, bun test 426, typecheck, docs gates). Both adversarial experiments reproduced: token deletion fails naming skill + missing token; a synthetic unmapped Owns: … transition trips the inverse guard. CI green across all checks.

Findings (deduplicated):

• P3, fixed in 57803d9: the test module's docstring documented an un-runnable invocation (python3 -m unittest tests.skill_transition_ownership_test; no tests/__init__.py). Now documents the discovery form.
• Per-spec, deferred (design decisions from test(plugin): guardrail — every owned lifecycle transition maps to an engine procedure and read-back #264's grooming, not defects): token matching is scoped to the SKILL.md+references union (a router sentence could move into references without failing the lint), and the inverse guard matches lowercase transition only. Both are the deliberate category-over-literal tradeoff; revisit only if the class of bug recurs at router level.

Wording note: #264's "runs under the bun test gate" is satisfied via the CI unittest discover step (.github/workflows/ci.yml), not bun test itself — enforcement intent delivered.

No unresolved P1/P2 findings. Ready for wf-delivery.

[aagnone3]

Final compounding check
Head: 57803d9
Result: captured
Artifacts: plugins/agentic-engineering/tests/skill_transition_ownership_test.py; plugins/agentic-engineering/skills/wf-grooming/SKILL.md; plugins/agentic-engineering/skills/wf-development/SKILL.md; plugins/agentic-engineering/skills/wf-delivery/SKILL.md
Reason: the durable lesson (an owned lifecycle transition must state its engine procedure and observable read-back) is encoded in the router prose and enforced by the guardrail test in this same PR, per the working agreement's prefer-a-test rule; incident record lives in #262.