Rename agentic-engineering-plugin to agentic-engineering in all URLs#3
Merged
Conversation
The GitHub repo was already renamed to agentic-engineering but references across 12 files still pointed to the old agentic-engineering-plugin name. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Adds a PreToolUse hook that denies any gh pr create command targeting EveryInc/compound-engineering-plugin. PRs must target origin (aagnone3/agentic-engineering) instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
15 tasks
3 tasks
10 tasks
aagnone3
added a commit
that referenced
this pull request
Jul 19, 2026
… cleanup recipes Address /workflows-review findings on PR #206: - P1: land-docs/land-plan-docs green-path cleanup called is_linked_worktree from a separate Bash invocation (function out of scope -> exit 127 -> wrong else-branch checkout that fails in a worktree) and led with 'if' (breaks the unattended allowed-tools first-token contract, gotcha #3). Replace with land-pr-style separate git-leading leaves, predicate evaluated in prose. - P2: reframe land-pr step 6 as two paths + a shared pre-delete guard (Leaf C was a cross-cutting guard, not a mutually-exclusive leaf). - P3: land-pr Leaf C guard uses whole-line grep -qxF. Findings recorded in todos/005-008.
aagnone3
added a commit
that referenced
this pull request
Jul 19, 2026
* fix(land-pr): worktree-safe merge-verify + post-merge cleanup Rework land-pr steps 5-6 and Success criteria to branch on worktree context: state-based merge verification, canonical is_linked_worktree predicate, base resolved from the PR, a three-leaf cleanup tree, and teardown deferred to gc_worktrees with both coverage caveats. Classic single-tree path is unchanged. Also materializes the join-keyed plan doc for #182. Closes #183 * fix(land-docs,land-plan-docs): extend worktree-safe cleanup; add git-worktree gc note Reuse the canonical is_linked_worktree predicate (byte-identical to land-pr) in land-docs and land-plan-docs: make setup and cleanup context-aware (no checkout of a held default from a linked worktree; git fetch + defer teardown to gc), and repair land-plan-docs's half-converted BASE handling. Add a companion note to git-worktree cross-referencing the land-* teardown deferral and gc's coverage limits. Closes #184 Closes #185 * docs(land-pr): make Leaf C branch-delete guard precedence explicit Clarify that the held-in-another-worktree guard runs before any git branch -d, including Leaf A's, per the AC pre-check note. * fix(land-docs,land-plan-docs): remove cross-invocation predicate from cleanup recipes Address /workflows-review findings on PR #206: - P1: land-docs/land-plan-docs green-path cleanup called is_linked_worktree from a separate Bash invocation (function out of scope -> exit 127 -> wrong else-branch checkout that fails in a worktree) and led with 'if' (breaks the unattended allowed-tools first-token contract, gotcha #3). Replace with land-pr-style separate git-leading leaves, predicate evaluated in prose. - P2: reframe land-pr step 6 as two paths + a shared pre-delete guard (Leaf C was a cross-cutting guard, not a mutually-exclusive leaf). - P3: land-pr Leaf C guard uses whole-line grep -qxF. Findings recorded in todos/005-008.
aagnone3
added a commit
that referenced
this pull request
Jul 19, 2026
…#3) (#208) The "detect an existing PR before branching" section led its decision with a standalone `if [ -n "$EXISTING" ] ...` block. Claude Code matches a skill's `allowed-tools` (Bash(gh *), Bash(git *), Read) by the pipeline's FIRST token, and `if` is not allow-listed — so an unattended run could stall on a permission prompt (the same class fixed for the cleanup recipes in PR #206 / issue #182, which predated this block). Fold the null-check into the `gh pr list --jq` with `// empty` so the recipe leads with `gh` (covered by Bash(gh *)), and evaluate the existence decision in prose — mirroring how PR #206 resolved the cleanup recipes (command-leading leaves, predicate evaluated in prose). allowed-tools unchanged. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agentic-engineering-pluginreferences withagentic-engineeringacross 12 filesTest plan
marketplace.jsonandplugin.jsonpass JSON validationbunx @aagnone3/agentic-plugin install agentic-engineeringstill works🤖 Generated with Claude Code