Skip to content

Fix incorrect text colour for tab item#1019

Merged
qroll merged 1 commit intomasterfrom
fix-tab-colour
Mar 19, 2026
Merged

Fix incorrect text colour for tab item#1019
qroll merged 1 commit intomasterfrom
fix-tab-colour

Conversation

@qroll
Copy link
Copy Markdown
Contributor

@qroll qroll commented Mar 19, 2026

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing apis or functionality to change)

Description of changes

  • Link to Figma
  • Fix text colour not being applied to tab item as the Typography was overriding the colour. Removed the Typography wrapper and applied the font style directly to the element instead

Checklist

  • Changes follow the project guidelines in CONTRIBUTING.md and CONVENTIONS.md
  • Looks good on mobile and tablet
  • Updated documentation
  • Added/updated tests

Screenshots

Before
Screenshot 2026-03-19 at 4 50 56 PM

After
Screenshot 2026-03-19 at 4 49 49 PM

@qroll qroll added this to the v3.3.0-canary.5 milestone Mar 19, 2026
@qroll qroll added the type: bug Something isn't working label Mar 19, 2026
@qroll qroll merged commit df2c717 into master Mar 19, 2026
1 check passed
@qroll qroll deleted the fix-tab-colour branch March 25, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants