Skip to content

Start multiple docker containers#4

Merged
matthewdunbar merged 4 commits into
masterfrom
start-multiple-containers
Apr 26, 2024
Merged

Start multiple docker containers#4
matthewdunbar merged 4 commits into
masterfrom
start-multiple-containers

Conversation

@matthewdunbar
Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread src/main/scala/com/lifeway/sbt/testdocker/StartTestDocker.scala Outdated
@rmmeans
Copy link
Copy Markdown
Member

rmmeans commented Apr 2, 2024

I'm good with the change. can you update the README for usage and bump the version to 1.1.0? I'm not sure how the version was previously set...

jordanfjellman
jordanfjellman previously approved these changes Apr 2, 2024
@matthewdunbar
Copy link
Copy Markdown
Collaborator Author

I updated the README. Versioning is handle by tags so I'll make sure to tag it appropriately.

Copy link
Copy Markdown

@jbellars jbellars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... did this version number need to be incremented?
README
For sbt 1.0:

addSbtPlugin("com.lifeway" % "sbt-testdocker" % "1.0.0")

@matthewdunbar matthewdunbar merged commit 266332e into master Apr 26, 2024
@matthewdunbar matthewdunbar deleted the start-multiple-containers branch April 26, 2024 12:32
@rmmeans
Copy link
Copy Markdown
Member

rmmeans commented Apr 26, 2024

@jbellars was right. The readme for what version needs to be updated too. Can someone hit this? @matthewdunbar @jordanfjellman @davidhulse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants