chore: remove unused hydra-core dependency#46
Closed
SergeiNikolenko wants to merge 1 commit into
Closed
Conversation
Member
Author
|
Superseded by #45, which now includes the same direct dependency cleanup ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hydra-corefrom runtime dependencies inpyproject.tomlWhy
hydra-coreis still listed as a runtime dependency onmain, but there are no tracked imports or references to Hydra in the current codebase. Matcha usesomegaconfdirectly for configuration loading/merging in the CLI and scripts.Validation
git grep -n 'hydra'only matchedpyproject.tomluv run python -c "import matcha; print(\"import ok\")"uv run matcha --helpuv run pytest tests/test_multigpu_cmd_build.py -qlobachevsky: freshuv syncin a clean checkout withouthydra-corelobachevsky:uv run matcha --helpNotes on server smoke run
I also attempted a full smoke inference run on
lobachevskyusing the standard 7EW9/05C Matcha smoke inputs.Two unrelated blockers showed up:
uv synccurrently resolvestorch 2.11.0+cu130, which does not work with the server driver (found version 12080), so CUDA is unavailable in the fresh environment.AttributeError: 'PDBBind' object has no attribute 'dataset_name'Neither issue is caused by this dependency cleanup.