Feat/healthcheck python hardening#276
Merged
Lightheartdevs merged 3 commits intoLight-Heart-Labs:mainfrom Mar 17, 2026
Merged
Conversation
Lightheartdevs
approved these changes
Mar 17, 2026
Collaborator
Lightheartdevs
left a comment
Lightheartdevs
left a comment
There was a problem hiding this comment.
Thorough rewrite. The HEAD-to-GET fallback, status code range matching, body regex, retry with backoff, and 1MiB body cap are all well-implemented. Backward compatible — existing healthcheck.py <url> usage still works. Clean exit codes.
Closes #215 — this supersedes it.
Approved.
Lightheartdevs
added a commit
that referenced
this pull request
Mar 17, 2026
Add credit for recently merged PRs: - yasinBursali: #270 (Bash 4+ macOS guard), #273 (.get() defaults) - championVisionAI: #280 (hardware detection), #275 (env validation), #276 (healthcheck hardening), #274 (Docker resilience), #277 (python command resolution) - bugman-007: #233 (disk space preflight), #238 (compose caching) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR expands healthcheck.py into a more capable universal healthcheck tool for HTTP and TCP targets, while preserving expected CLI behavior. It supports retries, status/body matching, structured JSON output, and GET fallback when HEAD is blocked.
Why:
Minimal container images often do not include curl or wget, and health checks need to be reliable across a wider range of services. This PR improves observability and compatibility without introducing external dependencies.
What changed:
Validation:
Notes:
This branch includes a small local follow-up fix so --help returns 0 instead of being forced to 2.