add film recommendations#14
Merged
LightInTheFire merged 4 commits intodevelopfrom Oct 18, 2025
Merged
Conversation
LightInTheFire
requested changes
Oct 14, 2025
Owner
|
Отдельный сервис хорошее решение, но нужно склеить данные из бд в нем же, а не внутри FilmRepository |
basementdoor
force-pushed
the
add-recommendations
branch
from
7ede73a to
15801e0
Compare
LightInTheFire
approved these changes
Oct 18, 2025
Alextrusk27
pushed a commit
that referenced
this pull request
Oct 18, 2025
* up to date to changes * fix conflicts * rebase changes * update methods for new code --------- Co-authored-by: Egor Ilyin <basementdoor@yandex.com>
n20va
pushed a commit
that referenced
this pull request
Oct 18, 2025
* up to date to changes * fix conflicts * rebase changes * update methods for new code --------- Co-authored-by: Egor Ilyin <basementdoor@yandex.com>
LightInTheFire
pushed a commit
that referenced
this pull request
Oct 22, 2025
* up to date to changes * fix conflicts * rebase changes * update methods for new code --------- Co-authored-by: Egor Ilyin <basementdoor@yandex.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Добавлена возможность получения рекоммендаций фильмов для юзеров с похожими предпочтениями на основе поставленных лайков
/users, но запрос фактически возвращает фильмы, более адекватным показалось создание отдельного сервиса для рекоммендаций (как черновой вариант). Включать вUserServiceImplточно некорректно, как вариант можно перенести часть логики с поиском фильмов вFilmserviceImpl, и тогда в контроллере добавить сервис фильмов.