Include mssError() when used#98
Open
Lightning11wins wants to merge 2 commits into
Open
Conversation
Greptile SummaryThis PR adds the missing Confidence Score: 5/5This PR is safe to merge — it makes no logic changes, only adds missing header includes. All changes are mechanical header additions to files that already use mssError(). No logic, no data flow, and no behavior is altered. No files require special attention.
|
| Filename | Overview |
|---|---|
| centrallix/cxss/cxss_credentials_db.c | Added missing #include cxlib/mtsession.h for mssError() usage; removed trailing newline. |
| centrallix/cxss/cxss_crypto.c | Added missing #include cxlib/mtsession.h for mssError() usage; removed trailing newline. |
| centrallix/cxss/cxss_util.c | Added missing #include cxlib/mtsession.h for mssError() usage; removed trailing newline. |
| centrallix/objectsystem/obj_content.c | Added missing #include cxlib/mtsession.h for mssError() usage; removed trailing newline. |
| centrallix/objectsystem/obj_session.c | Added missing #include cxlib/mtsession.h for mssError() usage; removed trailing newline. |
| centrallix/utility/obfuscate.c | Added missing #include cxlib/mtsession.h for mssError() usage; removed two trailing newlines. |
| centrallix/utility/param.c | Added missing #include cxlib/mtsession.h for mssError() usage; removed trailing newline. |
| centrallix/utility/ptod.c | Added missing #include cxlib/mtsession.h for mssError() usage; removed trailing newline. |
| centrallix/wgtr/apos.c | Added missing #include cxlib/mtsession.h for mssError() usage. |
| centrallix/wgtr/wgtr.c | Added missing #include cxlib/mtsession.h for mssError() usage. |
Reviews (3): Last reviewed commit: "Include "cxlib/mtsession.h" everywhere m..." | Re-trigger Greptile
Contributor
Author
|
Cleared for human review. |
… the file wasn't compiled.)
Contributor
Author
|
This PR is cleared for human review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some files call
msError()without includingcxlib/mtsession.h. This latent mistake caused compiler errors when I made an otherwise safe change in code I plan to commit to for #77 once it's not being reviewed.I'm making this a new PR because I don't want to mix even more mostly unrelated changes into the
dupsbranch, and I think these changes will be obviously safe on their own, so they should be trivial to review, approve, and merge.