This repository was archived by the owner on Oct 21, 2022. It is now read-only.
Support namespace-qualified forms for smart indent#19
Merged
ibdknox merged 1 commit intoLightTable:masterfrom Apr 28, 2014
Merged
Support namespace-qualified forms for smart indent#19ibdknox merged 1 commit intoLightTable:masterfrom
ibdknox merged 1 commit intoLightTable:masterfrom
Conversation
Member
|
looks good, thanks. |
ibdknox
added a commit
that referenced
this pull request
Apr 28, 2014
Support namespace-qualified forms for smart indent
Member
|
@glenjamin Are the above examples supposed to be function invocations? If so, could you explain why we want |
Author
|
The idea is to identify any form which accepts additional forms to execute. These are usually macros in practice, but the main defining feature is that they either begin with The namespace portion of the var name should be ignored, and only the name itself considered - this is why |
Member
|
Gotcha. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current smart indent behaviour for
defandwithstyle forms does not handle namespaces correctly.Before:
After: