Strip leading @ from reviewer handles in ship skill#21
Merged
sebastientaggart merged 2 commits intodevfrom Mar 26, 2026
Merged
Conversation
The gh CLI's --reviewer flag rejects handles with @ prefixes (e.g. @sebastientaggart), causing PR creation to fail with "Could not resolve user with login". The ship skill now instructs agents to strip @ from each comma-separated handle before constructing the --reviewer argument.
Contributor
Author
Review SummaryVerdict: APPROVE Findings
No blocking issues found. The change is consistent across the source template ( |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ship skill passes
DEFAULT_REVIEWERShandles directly togh pr create --reviewer, but theghCLI rejects handles with leading@prefixes (e.g.@sebastientaggart) with:Updated the ship skill template to instruct agents to strip any leading
@from each comma-separated handle before constructing the--reviewerargument. Both@aliceandalicenow work in config, and@org/teamcorrectly becomesorg/team.Issue #20