Skip to content

Fix deploy skill skip flow to find latest tag in branch history#42

Merged
sebastientaggart merged 2 commits intodevfrom
feature/combine-deploy-skill
Mar 27, 2026
Merged

Fix deploy skill skip flow to find latest tag in branch history#42
sebastientaggart merged 2 commits intodevfrom
feature/combine-deploy-skill

Conversation

@sebastientaggart
Copy link
Copy Markdown
Contributor

The "skip version bump" path in /deploy previously required a version tag on HEAD exactly (git describe --exact-match), which failed when HEAD had moved past the tag commit. This changes it to git describe --tags --abbrev=0 to find the most recent tag in the branch history.

Also updates ROADMAP.md to reflect the combined /deploy skill name (was still referencing /version and /release) and regenerates all adapter files.

Issue #36

sebastientaggart and others added 2 commits March 26, 2026 20:13
The "skip version bump" path previously required a tag on HEAD exactly,
which failed when HEAD had moved past the tag commit. Now uses
git describe --tags --abbrev=0 to find the most recent tag in the
branch history. Also updates ROADMAP.md to reflect the combined
/deploy skill name and regenerates adapter files.
@sebastientaggart
Copy link
Copy Markdown
Contributor Author

Review Summary

Verdict: APPROVE

Findings

  • [NOTE] The deploy skill's "skip" path change from git describe --exact-match --tags HEAD to git describe --tags --abbrev=0 is correct. The old command required the tag to be exactly on HEAD, which broke when any commit landed after the tag. The new command walks back through ancestors to find the most recent tag, which is the intended behavior for "skip version bump and use whatever we already tagged."

  • [NOTE] The removal of the hard rule "Never suggest what the developer should work on next" from the status skill is consistent with the new Step 6 ("What's next") feature, which deliberately adds actionable suggestions. The old rule and the new feature would contradict each other, so removing it is correct.

  • [NOTE] The "What's next" priority table in the status skill has a subtle ordering consideration: priorities 6 and 7 are not scoped to a specific branch type (unlike 1-5), so they act as fallbacks. Priority 6 ("Nothing in progress") fires before priority 7 ("Open issues in Up next"), which means if there are no open PRs but there ARE open issues, priority 7 would never match (since priority 6's condition — "no open PRs, no open issues" — would fail, correctly falling through to 7). The logic is sound.

  • [NOTE] The ROADMAP.md update replacing "version/release" with "deploy" accurately reflects the current skill naming. No issues.

  • [NOTE] All adapter files (.agents/, .claude/, .cursor/, .gemini/) are consistent with the source skill files (skills/deploy.md, skills/status.md). Hash footers are updated. Generated content matches the source of truth.

No issues found. The deploy fix is correct, the status "What's next" feature is well-structured, and all adapter files are properly synced.

@sebastientaggart sebastientaggart merged commit 3508e6b into dev Mar 27, 2026
2 checks passed
@sebastientaggart sebastientaggart mentioned this pull request Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant