Skip to content

Bundle CodeCannon command skill updates and bump submodule#17

Merged
sebastientaggart merged 3 commits intomainfrom
feature/codecannon-skill-updates-bundle
Apr 8, 2026
Merged

Bundle CodeCannon command skill updates and bump submodule#17
sebastientaggart merged 3 commits intomainfrom
feature/codecannon-skill-updates-bundle

Conversation

@sebastientaggart
Copy link
Copy Markdown
Member

Regenerates all CodeCannon-managed command skill files from the latest upstream templates and bumps the CodeCannon submodule to e11951e. Notable upstream improvements included:

  • Skill descriptions now carry a Code Cannon: prefix so the command family is discoverable as a group.
  • /submit-for-review gains Step 9, which offers to create follow-up GitHub issues for non-blocking review findings after a successful merge.
  • The review agent prompt now requires every finding to be phrased as a standalone sentence so it can be promoted into a ticket title without editing.

Also strips leftover stash-conflict markers from deploy, start, and submit-for-review (both .claude/commands/ and .cursor/rules/ adapters) that were never resolved from an earlier stash apply.

Closes #16

@sebastientaggart
Copy link
Copy Markdown
Member Author

Review Summary

Verdict: REQUEST CHANGES

Scope: generated CodeCannon skill/command markdown under .claude/ and .cursor/rules/, plus a CodeCannon submodule pointer bump. No source code changes.

Findings

  • [CRITICAL] The Read current version snippet in .claude/commands/deploy.md and .cursor/rules/deploy.mdc is broken: it renders as node -p \"require('./package.json').version\ — the double quotes are backslash-escaped inside a markdown bash fence (they should be bare "), and the trailing \ leaves the string unterminated. An agent copy-pasting this into a shell will fail. Fix the generator so the bash block emits node -p "require('./package.json').version".
  • [CRITICAL] .claude/commands/start.md and .cursor/rules/start.mdc contain unsubstituted template placeholders {{TICKET_LABEL_CREATION_ALLOWED}} in the "No label / creation" section. Raw mustache tokens should never reach generated output; the sync step is failing to resolve this variable (contrast with nearby references that were correctly replaced with the literal false).
  • [NOTE] The submodule bump (CodeCannon c951c5a → e11951e) is the source of the above regressions; once the upstream generator is fixed, re-run CodeCannon/sync.sh and force-push the regenerated files.

@sebastientaggart
Copy link
Copy Markdown
Member Author

Review Summary (Re-review)

Verdict: REQUEST CHANGES

Findings

  • [CRITICAL] .claude/commands/start.md and .cursor/rules/start.mdc still contain an unsubstituted {{BRANCH_DEV}} mustache placeholder on the Step 4 callout line (git checkout {{BRANCH_DEV}}), indicating the upstream template regeneration did not cover every placeholder site.
  • [NOTE] The prior CRITICAL about the broken node -p \"require('./package.json').version\" snippet in deploy.md / deploy.mdc is resolved — no such snippet remains.
  • [NOTE] The prior CRITICAL about {{TICKET_LABEL_CREATION_ALLOWED}} in start.md / start.mdc is resolved for that specific token, but substituted values now render awkward sentences like "omit (or create if false is true)" in the Important constraints section; upstream template wording could be tightened, non-blocking.

@sebastientaggart
Copy link
Copy Markdown
Member Author

Review Summary

Verdict: APPROVE

Findings

No issues found. Third-pass verification confirms the prior CRITICALs are resolved: deploy.md no longer contains the broken node -p snippet, no raw {{...}} mustache placeholders remain anywhere under .claude/commands/, .cursor/rules/, or .claude/review-agent-prompt.md, and the trunk-mode BRANCH_DEV callouts in start.md Steps 4 and 6 have been removed cleanly along with the corresponding .cursor/rules/start.mdc blocks. New content (Step 9 follow-up issue flow in submit-for-review.md/.mdc, the phrasing rule in review-agent-prompt.md, and the "Code Cannon:" description prefixes) is internally consistent and the CodeCannon submodule pointer advances as expected.

@sebastientaggart sebastientaggart merged commit ac4a70a into main Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bundle CodeCannon command skill updates and bump CodeCannon submodule

1 participant