Replace ScopedStateStore __getattr__ with explicit allow-list#18
Merged
sebastientaggart merged 1 commit intomainfrom Apr 8, 2026
Merged
Conversation
Member
Author
Review SummaryVerdict: APPROVE Findings
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
__getattr__catch-all onScopedStateStorethat delegated unknown attribute access to the underlyingStateStore. The wrapper now exposes only an explicit allow-list of proxied methods (list_state,entry_count,get_state,is_writable,set_state,clear_state), so any future write-capable method added toStateStore(e.g.bulk_set,purge) is invisible to plugins until explicitly proxied with the correct capability check.Audit of the current
StateStoresurface confirmed nothing was leaking today — all public methods were already explicitly proxied, and the priorname.startswith("_")guard blocked private attributes. This change closes the latent defense-in-depth gap flagged on PR #13.Added a regression test that injects a hypothetical
bulk_setonto the underlying store and asserts it is not reachable through the scoped wrapper.Closes #14