Deny state-only plugins from invoking actions#19
Merged
sebastientaggart merged 1 commit intomainfrom Apr 8, 2026
Merged
Conversation
Member
Author
Review SummaryVerdict: APPROVE FindingsNo issues found. Code looks correct and follows project conventions. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ScopedActionRegistry.run()previously denied onlyread-only, which allowedstate-onlyplugins to invoke arbitrary registered actions (including orchestrator commands likeagent.start). This contradicted the docstring intent thatstate-onlyhas no orchestrator access.Tightens
run()to requirefullcapability, clarifies thestate-onlydocstring bullet to say "cannot register or invoke actions", and extends the state-only test to pin the new behavior.Closes #15