Skip to content

Fix 'findings' terminology in prism-extractor agent#61

Merged
EiffL merged 1 commit into
mainfrom
update
Apr 14, 2026
Merged

Fix 'findings' terminology in prism-extractor agent#61
EiffL merged 1 commit into
mainfrom
update

Conversation

@EiffL
Copy link
Copy Markdown
Member

@EiffL EiffL commented Apr 14, 2026

Summary

  • Replaced "findings" with "claims" in the prism-extractor agent definition to avoid collision with the ASTRA schema term
  • In ASTRA, findings specifically means conclusions from the analysis itself (backed by output artifacts), while the extractor produces prior_insights (knowledge from literature). Using "findings" to describe what the extractor identifies in papers was ambiguous.
  • "Claims" aligns with the Insight.claim field name and is unambiguous

Test plan

  • Verify prism-extractor agent still works correctly with /prism-new paper extraction
  • Confirm no other files needed updates (audited all mentions of insights/findings across the repo)

🤖 Generated with Claude Code

In the ASTRA schema, "findings" specifically means conclusions from the
analysis itself (backed by output artifacts), not knowledge extracted
from literature. The extractor agent produces prior_insights, so using
"findings" to describe what it identifies in papers created ambiguity
with the ASTRA-specific term. Changed to "claims" which aligns with
the Insight.claim field name.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Member Author

@EiffL EiffL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@EiffL EiffL merged commit 940947c into main Apr 14, 2026
7 of 8 checks passed
@github-actions
Copy link
Copy Markdown

✅ Eval Results

Metric Value
Score 1.00
Build complete
Cost $1.46
Turns 63
Duration 430s
Prism 0.1.dev1+g44615a682 (44615a68)
Results Download

Graders

✅ spec_valid (1.00)
✅ all_materialized (1.00)

Full output
ytonaproxy01.net/toolbox/dbdcc8fc-baa1-4574-a209-a19e57c225ad/files/bulk-upload "HTTP/1.1 200 OK"
19:13:09 httpx HTTP Request: POST https://daytonaproxy01.net/toolbox/dbdcc8fc-baa1-4574-a209-a19e57c225ad/files/bulk-upload "HTTP/1.1 200 OK"
19:13:10 httpx HTTP Request: POST https://daytonaproxy01.net/toolbox/dbdcc8fc-baa1-4574-a209-a19e57c225ad/files/bulk-upload "HTTP/1.1 200 OK"
19:13:10 httpx HTTP Request: POST https://daytonaproxy01.net/toolbox/dbdcc8fc-baa1-4574-a209-a19e57c225ad/files/bulk-upload "HTTP/1.1 200 OK"
19:13:10 httpx HTTP Request: POST https://daytonaproxy01.net/toolbox/dbdcc8fc-baa1-4574-a209-a19e57c225ad/files/bulk-upload "HTTP/1.1 200 OK"
19:13:11 httpx HTTP Request: POST https://daytonaproxy01.net/toolbox/dbdcc8fc-baa1-4574-a209-a19e57c225ad/files/bulk-upload "HTTP/1.1 200 OK"
19:13:11 httpx HTTP Request: POST https://daytonaproxy01.net/toolbox/dbdcc8fc-baa1-4574-a209-a19e57c225ad/files/bulk-upload "HTTP/1.1 200 OK"
19:13:11 httpx HTTP Request: POST https://daytonaproxy01.net/toolbox/dbdcc8fc-baa1-4574-a209-a19e57c225ad/files/bulk-upload "HTTP/1.1 200 OK"
19:13:12 httpx HTTP Request: POST https://daytonaproxy01.net/toolbox/dbdcc8fc-baa1-4574-a209-a19e57c225ad/files/bulk-upload "HTTP/1.1 200 OK"
19:13:12 httpx HTTP Request: POST https://daytonaproxy01.net/toolbox/dbdcc8fc-baa1-4574-a209-a19e57c225ad/files/bulk-upload "HTTP/1.1 200 OK"
19:13:12 httpx HTTP Request: POST https://daytonaproxy01.net/toolbox/dbdcc8fc-baa1-4574-a209-a19e57c225ad/files/bulk-upload "HTTP/1.1 200 OK"
19:13:13 httpx HTTP Request: POST https://daytonaproxy01.net/toolbox/dbdcc8fc-baa1-4574-a209-a19e57c225ad/files/bulk-upload "HTTP/1.1 200 OK"
19:13:13 httpx HTTP Request: POST https://daytonaproxy01.net/toolbox/dbdcc8fc-baa1-4574-a209-a19e57c225ad/files/bulk-upload "HTTP/1.1 200 OK"
19:13:13 httpx HTTP Request: POST https://daytonaproxy01.net/toolbox/dbdcc8fc-baa1-4574-a209-a19e57c225ad/files/bulk-upload "HTTP/1.1 200 OK"
19:13:14 httpx HTTP Request: POST https://daytonaproxy01.net/toolbox/dbdcc8fc-baa1-4574-a209-a19e57c225ad/files/bulk-upload "HTTP/1.1 200 OK"
19:13:14 httpx HTTP Request: POST https://daytonaproxy01.net/toolbox/dbdcc8fc-baa1-4574-a209-a19e57c225ad/files/bulk-upload "HTTP/1.1 200 OK"
19:13:14 httpx HTTP Request: POST https://daytonaproxy01.net/toolbox/dbdcc8fc-baa1-4574-a209-a19e57c225ad/files/bulk-upload "HTTP/1.1 200 OK"
19:20:28 prism.eval.sandbox Deleted sandbox for trial build-snae-0
  snae trial 0: score=1.00 complete

Prism: 0.1.dev1+g44615a682 (HEAD 44615a68)

  Eval Results: Scores  
┏━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Task ┃     Score     ┃
┡━━━━━━╇━━━━━━━━━━━━━━━┩
│ snae │ 1.00 +/- 0.00 │
│      │ pass@k: 100%  │
└──────┴───────────────┘

   Eval Results: Cost &   
         Duration         
┏━━━━━━┳━━━━━━━━━━━━━━━━━┓
┃ Task ┃ Cost / Duration ┃
┡━━━━━━╇━━━━━━━━━━━━━━━━━┩
│ snae │      $1.46      │
│      │      430s       │
└──────┴─────────────────┘

Total: 1 trials, $1.46, 430s

Results saved to: eval-results/build-44615a68/results.json

@aboucaud aboucaud deleted the update branch May 8, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant