nvFuser Executor: Ensure cross-entropy loss fwd is not recomputed when computing bwd #2180
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In #2043 we added custom decompositions for cross-entropy loss fwd and bwd for the nvfuser executor.
We noticed that when computing the bwd, we would end up recomputing the fwd. The final trace of the bwd would look something like:
In this PR we mark the fwd operator to not be used to recompute in the bwd computation.
Our trace for the bwd will look something like:
Not recomputing the FWD significantly improves performance of BWD.