Fixes baddbmm() got an unexpected keyword argument 'batch1' #2228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanYashchuk
approved these changes
Jun 13, 2025
Collaborator
IvanYashchuk
left a comment
IvanYashchuk
left a comment
There was a problem hiding this comment.
PyTorch should use more of positional-only arguments, but this can't be fixed anymore without breaking users' code. Thank you for the fix!
Collaborator
Author
|
Hi @t-vi , it's ready to merge |
t-vi
approved these changes
Jun 13, 2025
Collaborator
t-vi
left a comment
t-vi
left a comment
There was a problem hiding this comment.
Thank you @kiya00 @IvanYashchuk
Borda
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
related to #2169 , fixes an issue where thunder fails when calling
baddbmm(x, batch1=a, batch2=b)using keyword arguments.PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃