Skip to content

Fix torch.gather function signature to accept input passed as keyword argument #2250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mruberry merged 2 commits into from
Jun 18, 2025
Merged

Fix torch.gather function signature to accept input passed as keyword argument #2250

mruberry merged 2 commits into from
Jun 18, 2025

Conversation

@kiya00
Copy link
Collaborator

@kiya00 kiya00 commented Jun 17, 2025 •
edited by IvanYashchuk
Loading

Fixes the error gather() got an unexpected keyword argument 'input', gather() got some positional-only arguments passed as keyword arguments: 'input'

@kiya00 kiya00 requested review from lantiga, mruberry and t-vi as code owners June 17, 2025 15:36
IvanYashchuk
IvanYashchuk reviewed Jun 17, 2025
View reviewed changes
@IvanYashchuk IvanYashchuk changed the title fix gather function signature Fix torch.gather function signature to accept input passed as keyword argument Jun 17, 2025
@kiya00
Copy link
Collaborator Author

kiya00 commented Jun 18, 2025

Hi @t-vi @mruberry , it's ready to merge

mruberry
mruberry approved these changes Jun 18, 2025
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry mruberry merged commit 5323366 into main Jun 18, 2025
49 checks passed
@mruberry mruberry deleted the fix_gather branch June 18, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IvanYashchuk IvanYashchuk IvanYashchuk approved these changes

@mruberry mruberry mruberry approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@t-vi t-vi Awaiting requested review from t-vi

Assignees

No one assigned

Labels

operators

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kiya00 @IvanYashchuk @mruberry