Skip to content

Conversation

@kshitij12345
Copy link
Collaborator

Currently the NB fails with

[rank0]:   File "/opt/pytorch/lightning-thunder/notebooks/dev_tutorials/thunder_fsdp_simple_example.py", line 49, in <module>
[rank0]:     cmodel = thunder.jit(thunder.distributed.fsdp(model))
[rank0]:                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[rank0]:   File "/opt/pytorch/lightning-thunder/thunder/distributed/__init__.py", line 435, in fsdp
[rank0]:     raise TypeError(
[rank0]: TypeError: Expected `model` to be of type `thunder.core.module.ThunderModule`, but got Sequential

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added the ci label Oct 10, 2025
@t-vi t-vi merged commit 793630e into main Oct 10, 2025
49 of 51 checks passed
@t-vi t-vi deleted the fix-nb-fsdp branch October 10, 2025 17:16
@t-vi
Copy link
Collaborator

t-vi commented Oct 10, 2025

This does the trick for fixing notebook ci.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants