[benchmark_inference] Update from_linear and from_grouped_linear to accept fqn: str
#2631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
crcrpar
requested review from
KaelanDt,
lantiga,
mruberry and
t-vi
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the from_linear and from_grouped_linear static methods to accept an optional fqn (fully qualified name) parameter, aligning with changes made to the replace function in PR #2620.
- Added optional
fqn: str | None = Noneparameter to both static methods - Added missing
super().__init__()call inNVFP4InferenceGroupedLinear.__init__
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
kshitij12345
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As per title, to work with the updated replace function in #2620