Skip to content

Conversation

@deependujha
Copy link
Collaborator

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #253 .

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@deependujha deependujha changed the title Nitpick/random state best practice Nitpick: random state best practice Aug 10, 2024
@codecov
Copy link

codecov bot commented Aug 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@a406715). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             main   #326   +/-   ##
=====================================
  Coverage        ?    78%           
=====================================
  Files           ?     34           
  Lines           ?   4975           
  Branches        ?      0           
=====================================
  Hits            ?   3876           
  Misses          ?   1099           
  Partials        ?      0           

@tchaton tchaton merged commit 95782ab into Lightning-AI:main Aug 10, 2024
@deependujha deependujha deleted the nitpick/random-state-best-practice branch August 16, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Random state best practices

2 participants