Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Sep 16, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Discussed with @justusschock that SDK includes inside lightning_cloud and LitDAta also uses SDK, so it would be safer if litData uses single lightning_cloud codebase

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda requested a review from ethanwharris September 16, 2024 15:28
@Borda Borda enabled auto-merge (squash) September 16, 2024 15:28
@codecov
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78%. Comparing base (6e538cc) to head (32406d8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #369   +/-   ##
===================================
  Coverage    78%    78%           
===================================
  Files        34     34           
  Lines      5016   5015    -1     
===================================
+ Hits       3929   3930    +1     
+ Misses     1087   1085    -2     

@Borda Borda added enhancement New feature or request dependencies Pull requests that update a dependency file labels Sep 16, 2024
@bhimrazy
Copy link
Collaborator

Looks like the authentication step is failing. Do we need to update the token? @Borda

                    "Authentication failed. Please run `lightning login`.")
E               click.exceptions.ClickException: Authentication failed. Please run `lightning login`.
```"

@Borda
Copy link
Collaborator Author

Borda commented Sep 16, 2024

Looks like the authentication step is failing. Do we need to update the token?

I don't see any auth token, so likely we need to update the testing mock

@Borda Borda merged commit 6af82c7 into main Sep 16, 2024
@Borda Borda deleted the pkg/sdk branch September 16, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants