Skip to content

Conversation

@deependujha
Copy link
Collaborator

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78%. Comparing base (5cae73c) to head (06de540).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #383   +/-   ##
===================================
  Coverage    78%    78%           
===================================
  Files        34     34           
  Lines      5022   5022           
===================================
  Hits       3931   3931           
  Misses     1091   1091           

@deependujha
Copy link
Collaborator Author

the failing tests are bcoz of this:
#375 (comment)

It was fixed in the fsspec PR, but bcoz of some issue, it was reverted.

@bhimrazy
Copy link
Collaborator

the failing tests are bcoz of this: #375 (comment)

It was fixed in the fsspec PR, but bcoz of some issue, it was reverted.

Let's raise an issue for this and we can address it in a new separate PR if the changes were not dependent on fsspec.

@deependujha deependujha merged commit f974902 into main Sep 26, 2024
@deependujha deependujha deleted the deependujha-patch-1 branch September 26, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants