Skip to content

Conversation

@bhimrazy
Copy link
Collaborator

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@bhimrazy bhimrazy added the documentation Improvements or additions to documentation label Oct 28, 2024
@bhimrazy bhimrazy self-assigned this Oct 28, 2024
@bhimrazy bhimrazy requested a review from tchaton as a code owner October 28, 2024 19:04
@codecov
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78%. Comparing base (32194cd) to head (fec02d7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #405   +/-   ##
===================================
  Coverage    78%    78%           
===================================
  Files        34     34           
  Lines      5045   5045           
===================================
  Hits       3954   3954           
  Misses     1091   1091           

@tchaton tchaton merged commit a9cf751 into Lightning-AI:main Oct 28, 2024
28 of 29 checks passed
@bhimrazy bhimrazy deleted the docs/add-custom-cache-dir branch October 28, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants