Skip to content

Add missing interruptible argument for creating jobs #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Add missing interruptible argument for creating jobs #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a06bc7
update
tchaton Nov 21, 2024
05a55b9
update
tchaton Nov 21, 2024
5b38e56
update
tchaton Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/litdata/__about__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

import time

__version__ = "0.2.30"
__version__ = "0.2.31"
__author__ = "Lightning AI et al."
__author_email__ = "pytorch@lightning.ai"
__license__ = "Apache-2.0"
Expand Down
2 changes: 2 additions & 0 deletions src/litdata/streaming/resolver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,7 @@ def _execute(
num_nodes: int,
machine: Optional["Machine"] = None,
command: Optional[str] = None,
interruptible: bool = False,
) -> None:
"""Remotely execute the current operator."""
if not _LIGHTNING_SDK_AVAILABLE:
Expand All @@ -370,6 +371,7 @@ def _execute(
teamspace_id=studio._teamspace.id,
cluster_id=studio._studio.cluster_id,
machine=machine or studio._studio_api.get_machine(studio._studio.id, studio._teamspace.id),
interruptible=interruptible,
)

has_printed = False
Expand Down
1 change: 1 addition & 0 deletions tests/streaming/test_resolver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,7 @@ def print_fn(msg, file=None):
"teamspace_id": "teamspace_id",
"cluster_id": "cluster_id",
"machine": "cpu",
"interruptible": False,
}

generated_kwargs = (
Expand Down
Loading